Skip to content

[Notifier] Remove SentMessage paragraph #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

[Notifier] Remove SentMessage paragraph #15131

merged 1 commit into from
Mar 24, 2021

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Mar 21, 2021 •
edited
Loading

The Notifier's send method does not return a SentMessage object: https://github.com/symfony/symfony/blob/5.2/src/Symfony/Component/Notifier/NotifierInterface.php#L26

Only the Chatter and Texter classes send methods return a SendMessage.

@jschaedl
Remove SentMessage paragraph
7bbfe94 
The Notifier's `send` method does not return a `SentMessage` object: https://github.com/symfony/symfony/blob/5.2/src/Symfony/Component/Notifier/NotifierInterface.php#L26

Only the Chatter and Texter classes `send` methods returns a `SendMessage`.
@javiereguiluz
Copy link
Member

Thanks Jan.

@javiereguiluz javiereguiluz merged commit 337a76d into symfony:5.2 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschaedl @javiereguiluz @carsonbot